jhungund commented on code in PR #6250:
URL: https://github.com/apache/hbase/pull/6250#discussion_r1770806202
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java:
##########
@@ -51,51 +50,53 @@ private BucketProtoUtils() {
}
static BucketCacheProtos.BucketCacheEntry toPB(BucketCache cache,
- BucketCacheProtos.BackingMap backingMap) {
+ BucketCacheProtos.BackingMap.Builder backingMapBuilder) {
return
BucketCacheProtos.BucketCacheEntry.newBuilder().setCacheCapacity(cache.getMaxSize())
.setIoClass(cache.ioEngine.getClass().getName())
.setMapClass(cache.backingMap.getClass().getName())
.putAllDeserializers(CacheableDeserializerIdManager.save())
-
.putAllCachedFiles(toCachedPB(cache.fullyCachedFiles)).setBackingMap(backingMap)
+ .putAllCachedFiles(toCachedPB(cache.fullyCachedFiles))
+ .setBackingMap(backingMapBuilder.build())
Review Comment:
We need to pass an empty backingmap here otherwise we see an exception of an
incomplete object. Hence, we just pass an empty backing map along with the
metadata. Subsequently, we persist all entries of the backing map in chunks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
