Apache9 commented on code in PR #6235:
URL: https://github.com/apache/hbase/pull/6235#discussion_r1770557900
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java:
##########
@@ -303,6 +303,7 @@ public void publishReadTiming(String znode, String server,
long msTime) {
*/
public static class RegionStdOutSink extends StdOutSink {
private Map<String, LongAdder> perTableReadLatency = new HashMap<>();
+ private Map<String, LongAdder> perTableWriteLatency = new HashMap<>();
Review Comment:
Do we still need to global writeLatency below?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java:
##########
@@ -1131,8 +1134,8 @@ private void printUsageAndExit() {
System.err.println(" -f <B> exit on first error; default=true");
System.err.println(" -failureAsError treat read/write failure as error");
System.err.println(" -t <N> timeout for canary-test run;
default=600000ms");
- System.err.println(" -writeSniffing enable write sniffing");
- System.err.println(" -writeTable the table used for write sniffing;
default=hbase:canary");
Review Comment:
I do not think we should remove this flag? People may want to use this flag
to specify a different write table for canary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
