[ https://issues.apache.org/jira/browse/HBASE-28810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880503#comment-17880503 ]
Hudson commented on HBASE-28810: -------------------------------- Results for branch branch-2.6 [build #197 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/197/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/197/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/197/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/197/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/197/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk17 hadoop3 checks{color} -- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/197/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Improve BackupLogCleaner naming, debug logging > ---------------------------------------------- > > Key: HBASE-28810 > URL: https://issues.apache.org/jira/browse/HBASE-28810 > Project: HBase > Issue Type: Bug > Components: backup&restore > Affects Versions: 2.6.0, 2.6.1 > Reporter: Ray Mattingly > Assignee: Ray Mattingly > Priority: Major > Labels: pull-request-available > Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1 > > > While implementing HBase's incremental backups across a few hundred clusters, > we continue to step on some rakes. Now and again, we find old WALs piling up > due to a poorly cleaned up BackupInfo, or a bug in the BackupLogCleaner, etc. > The BackupLogCleaner is difficult to debug for a couple of reasons: > # It has a lack of useful debug logging > # It has [a misleadingly named > method|https://github.com/HubSpot/hbase/blob/2d08fa67dfe9458260bc0be3ebc7bbd769850190/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java#L83-L83] > (this method returns the newest backup ts, not the oldest) > I'm going to introduce a small refactor that will alleviate these pain points. -- This message was sent by Atlassian Jira (v8.20.10#820010)