guluo2016 commented on code in PR #6119:
URL: https://github.com/apache/hbase/pull/6119#discussion_r1693962526
##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -114,6 +114,9 @@ def compact(table_or_region_name, family = nil, type =
'NORMAL')
#----------------------------------------------------------------------------------------------
# Switch compaction on/off at runtime on a region server
def compaction_switch(on_or_off, regionserver_names)
+ unless /true|false/i.match?(on_or_off)
+ raise ArgumentError, 'compactionSwitch first argument only accepts
"true" or "false"'
Review Comment:
`compactionSwitch first argument ...` -> `compaction_switch first
argument ...`, would this be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
