NihalJain commented on code in PR #119:
URL: https://github.com/apache/hbase-connectors/pull/119#discussion_r1284189084
##########
spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/datasources/JavaBytesEncoder.scala:
##########
@@ -25,84 +25,101 @@ import org.apache.yetus.audience.InterfaceStability
import org.apache.spark.sql.types._
/**
- * The ranges for the data type whose size is known. Whether the bound is
inclusive
- * or exclusive is undefind, and upper to the caller to decide.
- *
- * @param low: the lower bound of the range.
- * @param upper: the upper bound of the range.
- */
+ * The ranges for the data type whose size is known. Whether the bound is
inclusive or exclusive
+ * is undefind, and upper to the caller to decide.
+ *
+ * @param low:
+ * the lower bound of the range.
+ * @param upper:
+ * the upper bound of the range.
+ */
@InterfaceAudience.LimitedPrivate(Array(HBaseInterfaceAudience.SPARK))
@InterfaceStability.Evolving
-case class BoundRange(low: Array[Byte],upper: Array[Byte])
+case class BoundRange(low: Array[Byte], upper: Array[Byte])
/**
- * The class identifies the ranges for a java primitive type. The caller needs
- * to decide the bound is either inclusive or exclusive on its own.
- * information
- *
- * @param less: the set of ranges for LessThan/LessOrEqualThan
- * @param greater: the set of ranges for GreaterThan/GreaterThanOrEqualTo
- * @param value: the byte array of the original value
- */
+ * The class identifies the ranges for a java primitive type. The caller needs
to decide the bound
+ * is either inclusive or exclusive on its own. information
+ *
+ * @param less:
+ * the set of ranges for LessThan/LessOrEqualThan
+ * @param greater:
+ * the set of ranges for GreaterThan/GreaterThanOrEqualTo
+ * @param value:
+ * the byte array of the original value
+ */
@InterfaceAudience.LimitedPrivate(Array(HBaseInterfaceAudience.SPARK))
@InterfaceStability.Evolving
case class BoundRanges(less: Array[BoundRange], greater: Array[BoundRange],
value: Array[Byte])
/**
- * The trait to support plugin architecture for different encoder/decoder.
- * encode is used for serializing the data type to byte array and the filter
is
- * used to filter out the unnecessary records.
- */
+ * The trait to support plugin architecture for different encoder/decoder.
encode is used for
+ * serializing the data type to byte array and the filter is used to filter
out the unnecessary
+ * records.
+ */
@InterfaceAudience.LimitedPrivate(Array(HBaseInterfaceAudience.SPARK))
@InterfaceStability.Evolving
trait BytesEncoder {
def encode(dt: DataType, value: Any): Array[Byte]
/**
- * The function performing real filtering operations. The format of
filterBytes depends on the
- * implementation of the BytesEncoder.
- *
- * @param input: the current input byte array that needs to be filtered out
- * @param offset1: the starting offset of the input byte array.
- * @param length1: the length of the input byte array.
- * @param filterBytes: the byte array provided by query condition.
- * @param offset2: the starting offset in the filterBytes.
- * @param length2: the length of the bytes in the filterBytes
- * @param ops: The operation of the filter operator.
- * @return true: the record satisfies the predicates
- * false: the record does not satisfy the predicates.
- */
- def filter(input: Array[Byte], offset1: Int, length1: Int,
- filterBytes: Array[Byte], offset2: Int, length2: Int,
- ops: JavaBytesEncoder): Boolean
+ * The function performing real filtering operations. The format of
filterBytes depends on the
+ * implementation of the BytesEncoder.
+ *
+ * @param input:
Review Comment:
its an issue with scalafmt plugin version we are using:
https://github.com/scalameta/scalafmt/issues/1387
Will try to bump up to fixed version and update here:
https://github.com/scalameta/scalafmt/pull/1987 or apply workaround (as last
resort)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
