[ https://issues.apache.org/jira/browse/HBASE-27984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746122#comment-17746122 ]
Hudson commented on HBASE-27984: -------------------------------- Results for branch branch-3 [build #20 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/20/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/20/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/20/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/20/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > NPE in MigrateReplicationQueueFromZkToTableProcedure recovery > ------------------------------------------------------------- > > Key: HBASE-27984 > URL: https://issues.apache.org/jira/browse/HBASE-27984 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 3.0.0-alpha-4 > Reporter: ruanhui > Assignee: Duo Zhang > Priority: Trivial > Fix For: 3.0.0-beta-1 > > > MigrateReplicationQueueFromZkToTableProcedure will restore the disabled state > of replication log cleaner barrier when replayed in master recovery, > {code:java} > @Override > protected void afterReplay(MasterProcedureEnv env) { > if (getCurrentState() == getInitialState()) { > // do not need to disable log cleaner or acquire lock if we are in the > initial state, later > // when executing the procedure we will try to disable and acquire. > return; > } > if > (!env.getReplicationPeerManager().getReplicationLogCleanerBarrier().disable()) > { > throw new IllegalStateException("can not disable log cleaner, this should > not happen"); > } > } {code} > however the replicationPeerManager has not been initialized when replay > procedure, which will cause a nullPointerException and master to abort. > Maybe better to add a check after the initialization of > replicationPeerManager to determine whether replication log cleaner barrier > needs to be disabled ? -- This message was sent by Atlassian Jira (v8.20.10#820010)