[ 
https://issues.apache.org/jira/browse/GUACAMOLE-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18046250#comment-18046250
 ] 

胡 欣 commented on GUACAMOLE-2174:
--------------------------------

We briefly looked at the source code of guacd, and there are a few design 
aspects that might be related to the issues we mentioned.
1) In version 1.6.0, when determining whether to combine display operations, we 
check the size limit of the combined image 
(guac_display_plan_rect_crosses_boundary). This restriction was not present in 
version 1.5.5. Currently, the value of guac_display_plan_should_combine in the 
source code is 9. Can this value be customized and modified? For example, can I 
change it to 10?
2) Regarding the logic for determining whether an image should use WebP 
compression, in version 1.5.5, the method 
__guac_common_surface_calculate_framerate was used to calculate the average 
frame rate for a given area. However, in version 1.6.0, the frame rate is 
simply calculated using op.current_frame - op.last_frame. Could this lead to 
less accurate frame rate calculations, thereby affecting the priority of WebP 
compression?


> The overall upgrade of Guacamole 1.6.0 results in a 200%~250% increase in 
> downlink traffic compared to 1.5.5. For this reason, we cannot upgrade.
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GUACAMOLE-2174
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-2174
>             Project: Guacamole
>          Issue Type: Bug
>            Reporter: 胡 欣
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to