[ 
https://issues.apache.org/jira/browse/GUACAMOLE-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907169#comment-17907169
 ] 

Nick Couchman commented on GUACAMOLE-1196:
------------------------------------------

After several days of digging around in this, I really think the thing to do at 
this point is just to flip the setting so that this has to be explicitly 
enabled when a connection is set up, rather than assuming that the connection 
will support it. libvncclient's support for this is badly broken - in addition 
to its own SendExtDesktopSize() method being somewhat broken, it actually 
doesn't have any way of detecting or determining whether the remote server 
supports resizing or not. There is a function called SupportsClient2Server that 
checks if a certain message type is supported; however, these flags are just 
statically set in the libvncclient code based on someone's knowledge of what 
various types of VNC servers support.

I still think there has to be a way to negotiate it, since tools like 
"vncviewer" on my local system are able to automatically choose whether or not 
to send the command, and they don't get disconnected by a cranky VNC server, 
but I haven't figured out, from packet captures or perusing source code for 
various tools how that is actually determined.

> Add auto resize to VNC sessions
> -------------------------------
>
>                 Key: GUACAMOLE-1196
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1196
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: Documentation, VNC
>            Reporter: Markus Bonet
>            Assignee: Nick Couchman
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> As discussed on the mailing list:
> {quote}
> I'm running a TigerVNC session on the server where Guacamole is installed. If 
> I connect with the TigerVNC viewer there is this nice feature that the remote 
> desktop is automatically resized if the viewer window is resized, like this 
> if offered with RDP already.
> Is there a configuration how to achieve this with a Guacamole session as well 
> for my VNC connection?
> {quote}
> Historically, this could not be done without corresponding support within 
> libvncclient. This should now be possible through handling the required 
> message type ({{SetDesktopSize}}):
> {quote}
> Unfortunately my team had to come up with a home baked solution for this 
> about 2 years ago. But it involved hacking up libvnc.
> BUT, I think it is feasible to submit a feature request for it because now 
> libvnc recently tagged a new version that includes the message type that 
> guacamole needs to do this:
> Tag: https://github.com/LibVNC/libvncserver/releases/tag/LibVNCServer-0.9.13
> New message: 
> https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#setdesktopsize
> {quote}
> See: 
> [http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/Auto-resize-of-VNC-sessions-td9511.html]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to