[ 
https://issues.apache.org/jira/browse/GUACAMOLE-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871905#comment-17871905
 ] 

Markus Bonet edited comment on GUACAMOLE-1196 at 8/8/24 3:32 PM:
-----------------------------------------------------------------

I tried the current code and was able to compile it. Is there some setting in 
the connection I need to activate the resize feature?

I got this messages in the log:

Aug 08 13:31:18 ds9 guacd[2035002]: Connected to VNC server, using protocol 
version 3.8
Aug 08 13:31:18 ds9 guacd[2035002]: VNC server default format:
Aug 08 13:31:18 ds9 guacd[2035002]:   32 bits per pixel.
Aug 08 13:31:18 ds9 guacd[2035002]:   Least significant byte first in each 
pixel.
Aug 08 13:31:18 ds9 guacd[2035002]:   TRUE colour: max red 255 green 255 blue 
255, shift red 16 green 8 blue 0
Aug 08 13:31:18 ds9 guacd[2035002]: Screen has not been initialized, cannot 
send resize.
Aug 08 13:31:18 ds9 guacd[2035002]: guacd[2035002]: ERROR:        Screen has 
not been initialized, cannot send resize.
Aug 08 13:46:25 ds9 guacd[2035002]: Screen has not been initialized, cannot 
send resize.
Aug 08 13:46:25 ds9 guacd[2035002]: guacd[2035002]: ERROR:        Screen has 
not been initialized, cannot send resize.
Aug 08 13:46:27 ds9 guacd[2035002]: Screen has not been initialized, cannot 
send resize.
Aug 08 13:46:27 ds9 guacd[2035002]: guacd[2035002]: ERROR:        Screen has 
not been initialized, cannot send resize.

 

2nd update: I uncommented the check and it works now:

Aug 08 14:21:45 ds9 guacd[2064633]: Connected to VNC server, using protocol 
version 3.8
Aug 08 14:21:45 ds9 guacd[2064633]: VNC server default format:
Aug 08 14:21:45 ds9 guacd[2064633]:   32 bits per pixel.
Aug 08 14:21:45 ds9 guacd[2064633]:   Least significant byte first in each 
pixel.
Aug 08 14:21:45 ds9 guacd[2064633]:   TRUE colour: max red 255 green 255 blue 
255, shift red 16 green 8 blue 0
Aug 08 14:21:45 ds9 guacd[2064633]: Got new framebuffer size: 3840x1918
Aug 08 14:22:08 ds9 guacd[2064633]: Got new framebuffer size: 1720x1045
Aug 08 14:22:14 ds9 guacd[2064633]: Got new framebuffer size: 3840x1918

 

BTW, looking back, this is somehow funny: "it's going to have to be something 
that we detect the capability (presence of that particular function) within the 
library and enable or disable at compile time, so that we don't break 
compatibility with older versions of the library."

Anyway, without the check on width or height not being 0, the version and your 
solution works very well for me. Thanks!


was (Author: mbo77):
I tried the current code and was able to compile it. Is there some setting in 
the connection I need to activate the resize feature?

I got this messages in the log:

Aug 08 13:31:18 ds9 guacd[2035002]: Connected to VNC server, using protocol 
version 3.8
Aug 08 13:31:18 ds9 guacd[2035002]: VNC server default format:
Aug 08 13:31:18 ds9 guacd[2035002]:   32 bits per pixel.
Aug 08 13:31:18 ds9 guacd[2035002]:   Least significant byte first in each 
pixel.
Aug 08 13:31:18 ds9 guacd[2035002]:   TRUE colour: max red 255 green 255 blue 
255, shift red 16 green 8 blue 0
Aug 08 13:31:18 ds9 guacd[2035002]: Screen has not been initialized, cannot 
send resize.
Aug 08 13:31:18 ds9 guacd[2035002]: guacd[2035002]: ERROR:        Screen has 
not been initialized, cannot send resize.
Aug 08 13:46:25 ds9 guacd[2035002]: Screen has not been initialized, cannot 
send resize.
Aug 08 13:46:25 ds9 guacd[2035002]: guacd[2035002]: ERROR:        Screen has 
not been initialized, cannot send resize.
Aug 08 13:46:27 ds9 guacd[2035002]: Screen has not been initialized, cannot 
send resize.
Aug 08 13:46:27 ds9 guacd[2035002]: guacd[2035002]: ERROR:        Screen has 
not been initialized, cannot send resize.

 

2nd update: I uncommented the check and it works now:

Aug 08 14:21:45 ds9 guacd[2064633]: Connected to VNC server, using protocol 
version 3.8
Aug 08 14:21:45 ds9 guacd[2064633]: VNC server default format:
Aug 08 14:21:45 ds9 guacd[2064633]:   32 bits per pixel.
Aug 08 14:21:45 ds9 guacd[2064633]:   Least significant byte first in each 
pixel.
Aug 08 14:21:45 ds9 guacd[2064633]:   TRUE colour: max red 255 green 255 blue 
255, shift red 16 green 8 blue 0
Aug 08 14:21:45 ds9 guacd[2064633]: Got new framebuffer size: 3840x1918
Aug 08 14:22:08 ds9 guacd[2064633]: Got new framebuffer size: 1720x1045
Aug 08 14:22:14 ds9 guacd[2064633]: Got new framebuffer size: 3840x1918

> Add auto resize to VNC sessions
> -------------------------------
>
>                 Key: GUACAMOLE-1196
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1196
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: Documentation, VNC
>            Reporter: Markus Bonet
>            Assignee: Nick Couchman
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> As discussed on the mailing list:
> {quote}
> I'm running a TigerVNC session on the server where Guacamole is installed. If 
> I connect with the TigerVNC viewer there is this nice feature that the remote 
> desktop is automatically resized if the viewer window is resized, like this 
> if offered with RDP already.
> Is there a configuration how to achieve this with a Guacamole session as well 
> for my VNC connection?
> {quote}
> Historically, this could not be done without corresponding support within 
> libvncclient. This should now be possible through handling the required 
> message type ({{SetDesktopSize}}):
> {quote}
> Unfortunately my team had to come up with a home baked solution for this 
> about 2 years ago. But it involved hacking up libvnc.
> BUT, I think it is feasible to submit a feature request for it because now 
> libvnc recently tagged a new version that includes the message type that 
> guacamole needs to do this:
> Tag: https://github.com/LibVNC/libvncserver/releases/tag/LibVNCServer-0.9.13
> New message: 
> https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#setdesktopsize
> {quote}
> See: 
> [http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/Auto-resize-of-VNC-sessions-td9511.html]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to