[ 
https://issues.apache.org/jira/browse/GUACAMOLE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841083#comment-17841083
 ] 

Libor Svehlak commented on GUACAMOLE-1719:
------------------------------------------

Hi [~vnick]. I have spend some time on analysis and the issue is with calling 
"PKG_CHECK_MODULES([AVCODEC], [libavcodec],, [have_libavcodec=no]);" in 
condition. See section 3.4. on 
https://autotools.info/pkgconfig/pkg_check_modules.html for details.

Updated script to fix the issue with latest Guacamole 1.5.5:

{noformat}
docker pull registry.suse.com/bci/bci-base:15.5
docker run -it registry.suse.com/bci/bci-base:15.5

zypper --non-interactive --no-refresh --no-gpg-checks install wget

mkdir /root/guacamole
cd /root/guacamole

wget 
https://rpmfind.net/linux/opensuse/distribution/leap/15.5/repo/oss/x86_64/libgsm1-1.0.14-150000.3.4.1.x86_64.rpm
rpm -i libgsm1-1.0.14-150000.3.4.1.x86_64.rpm

wget -O guacamole-server-1.5.5.tar.gz 
https://apache.org/dyn/closer.lua/guacamole/1.5.5/source/guacamole-server-1.5.5.tar.gz?action=download
tar -C . -xzf guacamole-server-1.5.5.tar.gz

zypper --non-interactive addrepo --no-gpgcheck 
https://download.opensuse.org/repositories/devel:/libraries:/c_c++/15.5/devel:libraries:c_c++.repo
zypper --non-interactive addrepo --no-gpgcheck 
https://download.opensuse.org/repositories/X11:/RemoteDesktop/SLE_15_SP3/X11:RemoteDesktop.repo
zypper --non-interactive --no-refresh --no-gpg-checks install vi autoconf awk 
gcc-c++ perl libpng16-devel libjpeg8-devel cairo-devel libuuid-devel 
libssh2-devel pango-devel freerdp-devel LibVNCServer-devel

cd guacamole-server-1.5.5
# Patch the configure.ac (bug GUACAMOLE-1718)
cp -a configure.ac configure.ac.before_first_patch
sed -i 's/\[\]\./\[\],/g' configure.ac
# Patch the configure.ac (bug GUACAMOLE-1719)
cp -a configure.ac configure.ac.before_second_patch
sed -i 's/# libavcodec/PKG_PROG_PKG_CONFIG()\n\n#\n# libavcodec/g' configure.ac
# Regenerate configure
autoconf
./configure --with-libavcodec=no
{noformat}

Just see the changes with:

{noformat}
diff configure.ac configure.ac.before_first_patch
{noformat}

and please incorporate them into the Git.


> Protocols RDP, SSH, Telnet are not supported when "--with-libavcodec=no" is 
> specified in configure script
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: GUACAMOLE-1719
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1719
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole
>    Affects Versions: 1.4.0
>            Reporter: Libor Svehlak
>            Priority: Major
>         Attachments: configure-output.log
>
>
> Documentation at 
> [https://guacamole.apache.org/doc/gug/installing-guacamole.html] specifies 
> that {{libavcodec}} is needed only when {{guacenc}} is required. Nevertheless 
> when {{--with-libavcodec=no}} is specified in {{configure}} script it is 
> causing that protocols RDP, SSH, Telnet are not supported.
> Prerequisite: All required packages for RDP, SSH, Telnet, VNC are installed:
> Steps to reproduce:
> {noformat}
> tar -xzf guacamole-server-1.4.0.tar.gz
> cd guacamole-server-1.4.0
> ./configure --with-libavformat=no
> {noformat}
> Output:
> {noformat}
> ------------------------------------------------
> guacamole-server version 1.4.0
> ------------------------------------------------
>    Library status:
>      freerdp2 ............ no
>      pango ............... no
>      libavcodec .......... disabled
>      libavformat.......... no
>      libavutil ........... no
>      libssh2 ............. yes
>      libssl .............. yes
>      libswscale .......... no
>      libtelnet ........... yes
>      libVNCServer ........ yes
>      libvorbis ........... yes
>      libpulse ............ no
>      libwebsockets ....... no
>      libwebp ............. yes
>      wsock32 ............. no
>    Protocol support:
>       Kubernetes .... no
>       RDP ........... no
>       SSH ........... no
>       Telnet ........ no
>       VNC ........... yes
>    Services / tools:
>       guacd ...... yes
>       guacenc .... no
>       guaclog .... yes
>    FreeRDP plugins: no
>    Init scripts: no
>    Systemd units: no
> Type "make" to compile guacamole-server.
> {noformat}
> Without the explicit specification of {{{}--with-libavformat=no{}}}:
> {noformat}
> tar -xzf guacamole-server-1.4.0.tar.gz
> cd guacamole-server-1.4.0
> ./configure
> {noformat}
> Output:
> {noformat}
> ------------------------------------------------
> guacamole-server version 1.4.0
> ------------------------------------------------
>    Library status:
>      freerdp2 ............ yes
>      pango ............... yes
>      libavcodec .......... no
>      libavformat.......... no
>      libavutil ........... no
>      libssh2 ............. yes
>      libssl .............. yes
>      libswscale .......... no
>      libtelnet ........... yes
>      libVNCServer ........ yes
>      libvorbis ........... yes
>      libpulse ............ no
>      libwebsockets ....... no
>      libwebp ............. yes
>      wsock32 ............. no
>    Protocol support:
>       Kubernetes .... no
>       RDP ........... yes
>       SSH ........... yes
>       Telnet ........ yes
>       VNC ........... yes
>    Services / tools:
>       guacd ...... yes
>       guacenc .... no
>       guaclog .... yes
>    FreeRDP plugins: /usr/lib64/freerdp2
>    Init scripts: no
>    Systemd units: no
> Type "make" to compile guacamole-server.
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to