[
https://issues.apache.org/jira/browse/GUACAMOLE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788214#comment-17788214
]
Mike Jumper edited comment on GUACAMOLE-1658 at 11/21/23 6:49 PM:
------------------------------------------------------------------
I think this also depended on a patched version of libssh2 that had more broad
SSH agent support via a {{LIBSSH2_CALLBACK_AUTH_AGENT}} callback which
otherwise does not exist in libssh2. It looks like something along these lines
was added via:
https://github.com/libssh2/libssh2/commit/bc4e619e76071393e466c29220fc4ef5764c2820
which is indeed part of libssh2 1.11.0. I'm not sure whether there are
additional code changes necessary beyond simply switching from
{{LIBSSH2_CALLBACK_AUTH_AGENT}} to {{LIBSSH2_CALLBACK_AUTHAGENT}}. If things do
work now without patching libssh2, we can probably get rid of the need to
manually add {{--enable-ssh-agent}} and just test for whether
{{LIBSSH2_CALLBACK_AUTHAGENT}} is declared.
(Correction: Agent forwarding is _not_ part of libssh2 1.10.0. It's part of
libssh2 1.11.0.)
was (Author: mike.jumper):
I think this also depended on a patched version of libssh2 that had more broad
SSH agent support via a {{LIBSSH2_CALLBACK_AUTH_AGENT}} callback which
otherwise does not exist in libssh2. It looks like something along these lines
was added via:
https://github.com/libssh2/libssh2/commit/bc4e619e76071393e466c29220fc4ef5764c2820
which is indeed part of libssh2 1.11.0. I'm not sure whether there are
additional code changes necessary beyond simply switching from
{{LIBSSH2_CALLBACK_AUTH_AGENT}} to {{LIBSSH2_CALLBACK_AUTHAGENT}}. If things do
work now without patching libssh2, we can probably get rid of the need to
manually add {{--enable-ssh-agent}} and just test for whether
{{LIBSSH2_CALLBACK_AUTHAGENT}} is declared.
(Correction: Agent forwarding is _not _ part of libssh2 1.10.0. It's part of
libssh2 1.11.0.)
> Unable to compile guacamole server with --enable-ssh-agent
> ----------------------------------------------------------
>
> Key: GUACAMOLE-1658
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1658
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Affects Versions: 1.4.0
> Environment: Rocky Linux 8.6 on x64, the latest libssh2 from remi
> repository, guacamole server version 1.4.0.
> Reporter: Pavel Kuzel
> Assignee: Nick Couchman
> Priority: Minor
> Labels: guacamole-server, ssh-agent
> Fix For: 1.5.4
>
>
> Hello there,
> a compilation of guacamole-server on Rocky Linux 8.6 with
> "--enable-ssh-agent" fails on the missing ssh_key.h header file. Please see
> the detail below:
> _make[2]: Entering directory
> '/home/guacamole/guacamole-server/src/protocols/ssh'_
> _CC libguac_client_ssh_la-argv.lo_
> _In file included from ssh.h:33,_
> _from argv.c:22:_
> _ssh_agent.h:26:10: fatal error: ssh_key.h: No such file or directory_
> _#include "ssh_key.h"_
> _^~~~~~~~~~~_
> _compilation terminated._
> Just for the record, I use the latest version of libssh2 (1.10.0) and I'd
> like to use the agent forwarding functionality within the guacamole server.
> Is there any way how to get it running in the current version of
> guacamole-server?
> Regards,
> Pavel
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
