[
https://issues.apache.org/jira/browse/GUACAMOLE-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Jumper reopened GUACAMOLE-1846:
------------------------------------
Reopening as build is failing with:
{code:none}
...
#8 25.33 make[3]: Entering directory `/build/guacamole-server/src/libguac'
#8 25.33 CC libguac_la-argv.lo
#8 25.55 CC libguac_la-audio.lo
#8 25.76 CC libguac_la-client.lo
#8 25.84 client.c: In function 'guac_client_start_pending_users_timer':
#8 25.84 client.c:497:12: error: missing braces around initializer
[-Werror=missing-braces]
#8 25.84 struct sigevent signal_config = { 0 };
#8 25.84 ^
#8 25.84 client.c:497:12: error: (near initialization for
'signal_config.sigev_value') [-Werror=missing-braces]
#8 25.84 client.c:512:12: error: missing braces around initializer
[-Werror=missing-braces]
#8 25.84 struct itimerspec time_config = { 0 };
#8 25.84 ^
#8 25.84 client.c:512:12: error: (near initialization for
'time_config.it_interval') [-Werror=missing-braces]
#8 25.84 cc1: all warnings being treated as errors
#8 25.84 make[3]: *** [libguac_la-client.lo] Error 1
#8 25.84 make[3]: Leaving directory `/build/guacamole-server/src/libguac'
#8 25.85 make[2]: *** [all-recursive] Error 1
#8 25.85 make[2]: Leaving directory `/build/guacamole-server/src/libguac'
#8 25.85 make[1]: *** [all-recursive] Error 1
#8 25.85 make[1]: Leaving directory `/build/guacamole-server'
#8 25.85 make: *** [all] Error 2
#8 ERROR: process "/bin/sh -c /bin/bash -e -x /build/build.sh" did not complete
successfully: exit code: 2
------
> [4/4] RUN /bin/bash -e -x /build/build.sh:
#8 25.84 ^
#8 25.84 client.c:512:12: error: (near initialization for
'time_config.it_interval') [-Werror=missing-braces]
#8 25.84 cc1: all warnings being treated as errors
#8 25.84 make[3]: *** [libguac_la-client.lo] Error 1
#8 25.84 make[3]: Leaving directory `/build/guacamole-server/src/libguac'
#8 25.85 make[2]: *** [all-recursive] Error 1
#8 25.85 make[2]: Leaving directory `/build/guacamole-server/src/libguac'
#8 25.85 make[1]: *** [all-recursive] Error 1
#8 25.85 make[1]: Leaving directory `/build/guacamole-server'
#8 25.85 make: *** [all] Error 2
{code}
I've seen this before - it has to do with structures that have their first
member being something that also requires braces for initialization. Newer
versions of GCC no longer consider this an issue, but old versions flag this
idiom when used with such a structure.
> Race condition can cause the first user for a connection to miss updates
> ------------------------------------------------------------------------
>
> Key: GUACAMOLE-1846
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1846
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Reporter: James Muehlner
> Priority: Minor
> Fix For: 1.5.4
>
>
> The changes in https://github.com/apache/guacamole-server/pull/39 seem to
> have introduced a potential race condition where the client thread may write
> updates to the broadcast socket before the first user (the owner) is added to
> the user list.
> This change was made nearly 7 years ago, and I never noticed it before
> testing my changes in https://github.com/apache/guacamole-server/pull/454, so
> it's fair to say that it doesn't happen very often. I only see it maybe 10%
> of the time, and only with an RDP connection using the Cygwin build of
> guacamole-server.
> The symptoms are that nothing but a blank screen is rendered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
