[ https://issues.apache.org/jira/browse/GUACAMOLE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Jumper reopened GUACAMOLE-1606: ------------------------------------ Assignee: Mike Jumper (was: Nick Couchman) Reopening to re-PR against {{staging/1.5.2}} for inclusion in a 1.5.2 bugfix release, alongside other bugs originally fixed for 1.6.0. > UserGroup Attributes not getting picked from the ModelUserGroup instead is > picked from Model User > ------------------------------------------------------------------------------------------------- > > Key: GUACAMOLE-1606 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1606 > Project: Guacamole > Issue Type: Bug > Components: guacamole > Affects Versions: 1.4.0 > Reporter: chitralekha > Assignee: Mike Jumper > Priority: Major > Labels: easyfix, patch > Fix For: 1.6.0 > > Attachments: image-2022-05-12-14-37-05-140.png > > Original Estimate: 2h > Remaining Estimate: 2h > > As per the framework code and design pattern , every ObjectTranslator class > exposes the method get<Model>Attributes to add and update attribute on > usercontext > For the usergroup looks like a mistake it using the UserAttributes instead of > UserGroupAttributes. > ====Code snippet From UserGroupObjectTranslator====== > @Override > public void filterExternalObject(UserContext userContext, APIUserGroup object) > throws GuacamoleException { > // Filter object attributes by defined schema > object.setAttributes(filterAttributes({*}userContext.getUserAttributes(){*}, > // {color:#FF0000}should be > {color}{color:#FF0000}getUserGroupAttributes(){color} > object.getAttributes())); > } > ======= > ======Code snippet form connectObjectTranslator ======= > @Override > public void filterExternalObject(UserContext userContext, > APIConnection object) throws GuacamoleException { > // Filter object attributes by defined schema > object.setAttributes(filterAttributes( > {*}userContext.getConnectionAttributes(){*}, object.getAttributes())); > } > > ============ -- This message was sent by Atlassian Jira (v8.20.10#820010)