[ 
https://issues.apache.org/jira/browse/GUACAMOLE-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576950#comment-17576950
 ] 

Mike Beynon commented on GUACAMOLE-1641:
----------------------------------------

[~vnick]: The problem is both setting client->__owner and 
user->info.protocol_version must happen before my new code calls 
`guac_client_owner_supports_required()`.  My latest change handles it 
transparently with a new mutex and condvar in the client struct.  This makes 
the prompt for username and/or password reliable even if called very early.

[https://github.com/mbeynon/guacamole-server/commit/a622cb43242ca602bbdfd77e859d947ed1b1aebe]

We still have to figure out why vSphere is disconnecting, but I still may want 
to submit the PR to get buy in for the approach.

> Add vSphere support to VNC protocol
> -----------------------------------
>
>                 Key: GUACAMOLE-1641
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1641
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole
>            Reporter: Mike Beynon
>            Priority: Minor
>
> vSphere bundles a VNC server into their ESXi hypervisor, and tunnels the VNC 
> protocol over a web socket to their client.  I'm working now to add support 
> to guacd to (1) take a vm object id name, (2) use the vSphere API to 
> establish a session with vCenter and request a webmks ticket, and (3) have 
> guacd connect to the appropriate ESXi server and port to setup the websocket 
> and then pass binary frames containing the VNC protocol.  The new parameters 
> for the guacd protocol will mean there's changes to guacamole-client also for 
> the webapp and the db storage for connection parameters.
> I plan to do this on the open source version.
> It's related to GUACAMOLE-591, except it will not show the entire VM catalog. 
>  Instead my changes will provide the mechanism in guacd, and later work can 
> add the catalog.
> Any suggestions how to proceed?  Things to do or things to avoid doing?
> Should I start with the latest apache or glyptodon source?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to