[
https://issues.apache.org/jira/browse/GEODE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541168#comment-17541168
]
ASF subversion and git services commented on GEODE-10328:
---------------------------------------------------------
Commit b89fc2ca2fe094a1344828d1e128db04273dcdfd in geode's branch
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b89fc2ca2f ]
GEODE-10328: close data store stats on cache close (#7716)
data store stats are now also closed on cache close or forced disconnect
> Cache close with partitioned regions does not close all the region's
> statistics
> -------------------------------------------------------------------------------
>
> Key: GEODE-10328
> URL: https://issues.apache.org/jira/browse/GEODE-10328
> Project: Geode
> Issue Type: Bug
> Components: core
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
>
> I noticed when looking at hprof memory dumps of a JVM whose cache had been
> closed that something was keeping the PartitionedRegion instances from being
> garbage collected. It turns out that the region's RegionPerfStats instance
> was not closed. Other stats for the region were closed but not the one owned
> by PartitionedRegionDataStore's bucketStats instance variable. This
> indicates that the PartitionedRegionDataStore.cleanUp method is not being
> called.
> It looks like the bug is in: PartitionedRegion.postDestroyRegion. It has a
> code path that handles Operation.CACHE_CLOSE and Operation.FORCED_DISCONNECT
> without calling "closePartitionedRegion" which invokes "dataStore.cleanup".
> This buggy code path has its reasons for not calling closePartitionedRegion.
> To fix this bug it would be easy and safe to have this code path call
> dataStore.getCachePerfStats().close()
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
