[
https://issues.apache.org/jira/browse/GEODE-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530953#comment-17530953
]
ASF GitHub Bot commented on GEODE-10237:
----------------------------------------
mmartell commented on PR #959:
URL: https://github.com/apache/geode-native/pull/959#issuecomment-1115397563
> This is, IMO, too much code to duplicate, and adding the new file rather
than editing the existing one really obscures the nature of this change. Please
try just editing `ThinClientTrasactions.hpp` and resubmit.
Good catch Blake! Not sure why I thought I needed to use a new header file.
As you point out, just needed to refactor the original header.
> Remove no-ack from transaction test
> -----------------------------------
>
> Key: GEODE-10237
> URL: https://issues.apache.org/jira/browse/GEODE-10237
> Project: Geode
> Issue Type: Test
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> The testThinClientTransactionWithSticky test is run against both ack and
> no-ack scoped regions. The no-ack scoped portion causes regular failure of
> this test and should be removed (see GEODE-9108).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
