[
https://issues.apache.org/jira/browse/GEODE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499654#comment-17499654
]
ASF subversion and git services commented on GEODE-10010:
---------------------------------------------------------
Commit ea20f2501a620c3b7baa3c621d2f4d21af3bdf58 in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ea20f25 ]
GEODE-10010: Improve accuracy of per-second Redis stats (#7358)
Code changes:
- Rather than a value that updates once per second, instantaneous
operations per second and instantaneous kilobytes read per second now
return a rolling average of those stats updated 16 times per second
- Introduce RollingAverageStat nested class in RedisStats
Test changes:
- Rename AbstractRedisInfoStatsIntegrationTest to match child classes
- Rather than measuring instantaneous per second stats after
operations have finished, sample them while operations are ongoing and
calculate the expected value based on the number of operations
performed in the one second prior to sampling.
- Change test tolerances from fixed value to 12.5% of expected value
Authored-by: Donal Evans <[email protected]>
> CI: InfoStatsIntegrationTest >
> opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring FAILED
> ------------------------------------------------------------------------------------------------------
>
> Key: GEODE-10010
> URL: https://issues.apache.org/jira/browse/GEODE-10010
> Project: Geode
> Issue Type: Bug
> Components: redis
> Affects Versions: 1.15.0, 1.16.0
> Reporter: Kristen
> Assignee: Donal Evans
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.16.0
>
>
> http://files.apachegeode-ci.info/builds/apache-support-1-15-main/1.15.0-build.0836/test-results/integrationTest/1643742213/
> {code:java}
> > Task :geode-for-redis:integrationTest
> InfoStatsIntegrationTest >
> opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring FAILED
> java.lang.AssertionError:
> Expecting actual:
> 13.0
> to be close to:
> 19.0
> by less than 4.0 but difference was 6.0.
> (a difference of exactly 4.0 being considered valid)
> at
> org.apache.geode.redis.internal.commands.executor.server.AbstractRedisInfoStatsIntegrationTest.opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring(AbstractRedisInfoStatsIntegrationTest.java:174)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> ...{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
