[
https://issues.apache.org/jira/browse/GEODE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497287#comment-17497287
]
ASF GitHub Bot commented on GEODE-10074:
----------------------------------------
gaussianrecurrence commented on a change in pull request #928:
URL: https://github.com/apache/geode-native/pull/928#discussion_r813704882
##########
File path: cppcache/src/CppCacheLibrary.cpp
##########
@@ -36,18 +33,15 @@ namespace apache {
namespace geode {
namespace client {
-void CppCacheLibrary::initLib(void) { ACE::init(); }
+void CppCacheLibrary::initLib(void) {}
-void CppCacheLibrary::closeLib(void) {
- // DO NOT CALL ACE::fini() HERE!
- // Things might be using ace beyond the life of Geode.
-}
+void CppCacheLibrary::closeLib(void) {}
std::string CppCacheLibrary::initProductLibDir() {
// otherwise... get the DLL path, and work backwards from it.
- char buffer[PATH_MAX + 1];
+ char buffer[4097];
buffer[0] = '\0';
- DllMainGetPath(buffer, PATH_MAX);
+ DllMainGetPath(buffer, 4096);
Review comment:
See below comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove ACE remains
> ------------------
>
> Key: GEODE-10074
> URL: https://issues.apache.org/jira/browse/GEODE-10074
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS A* geode-native contributor
> *I WANT TO* remove all the ACE remaining
> *SO THAT* geode-native does not depend on ACE anymore
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
