[ 
https://issues.apache.org/jira/browse/GEODE-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492780#comment-17492780
 ] 

ASF subversion and git services commented on GEODE-10021:
---------------------------------------------------------

Commit 9fa1c1b3afd1193bb4072501c0ff23008da8625e in geode's branch 
refs/heads/WIP-GEODE-9892 from Hale Bales
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9fa1c1b ]

GEODE-10021: Clean up RemoteTransactionDUnitTest (#7339)

Clean up RemoteTransactionDUnitTest for the next time this failure
occurs.

While trying to reproduce the failure described by GEODE-9929 I did some
clean up so I would be able to get more useful information out of the
failures. I cleaned up a lot of warnings, mostly using IntelliJ's tools.

I cleaned up:
- assertNull
- assertTrue
- assertFalse
- fail
- WaitCriterion
- added <Object> where required to get rid of warnings
- removed unnecessary throws of Exceptions on methods that don't throw
- in assertions switched the actual and expected to be the correct direction
- getGemfireCache (deprecated) -> getCache


> Clean up RemoteTrasactionDUnitTest
> ----------------------------------
>
>                 Key: GEODE-10021
>                 URL: https://issues.apache.org/jira/browse/GEODE-10021
>             Project: Geode
>          Issue Type: Improvement
>    Affects Versions: 1.16.0
>            Reporter: Hale Bales
>            Assignee: Hale Bales
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.16.0
>
>
> I have been working on GEODE-9929 and the failing DUnitTest has a lot of 
> errors. I want to clean up some of the errors where I can use find and 
> replace, as well as a couple of changes to make it easier for the next person 
> who works on GEODE-9929.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to