[ https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490367#comment-17490367 ]
ASF GitHub Bot commented on GEODE-10004: ---------------------------------------- pdxcodemonkey commented on a change in pull request #917: URL: https://github.com/apache/geode-native/pull/917#discussion_r803874498 ########## File path: CMakeLists.txt ########## @@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product build date") set(PRODUCT_SOURCE_REVISION "0000000000000000000000000000000000000000" CACHE STRING "Product source SHA") set(PRODUCT_SOURCE_REPOSITORY "<unspecified>" CACHE STRING "Product source branch") set(PRODUCT_BITS "${BUILD_BITS}bit") +set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0-build.546" CACHE STRING "First build containing AuthenticationExpiredException") Review comment: Just because that's a more complex fix, and neither of us really have a clue how to implement it using cmake. Like how would we do this, go dump the class list from a jar file after we find Geode? Which of the umpteen Geode jar files should we look in? How do we run the jar tool at this stage via cmake? After we do or do not find the exception class, how do we put that back into a cmake variable we can use to conditionally compile our Java? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Starting server should fail fast when server port and redis port are the same > ----------------------------------------------------------------------------- > > Key: GEODE-10004 > URL: https://issues.apache.org/jira/browse/GEODE-10004 > Project: Geode > Issue Type: Bug > Components: gfsh, redis > Affects Versions: 1.15.0, 1.16.0 > Reporter: Hale Bales > Priority: Major > Labels: pull-request-available > > When starting a cluster with GFSH with geode-for-redis enabled, starting a > server fails when the geode-for-redis-port and server-port are set to the > same port. It fails with the below stacktrace, but does not fail fast. We > should be able to detect this issue before we reach the point of getting a > bind exception. > stacktrace: > {code:java} > Exception in thread "main" java.lang.RuntimeException: An IO error occurred > while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on > hbales-a01.vmware.com[6379]: Failed to create server socket on > 192.168.0.4[6379] > at > org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863) > at > org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739) > at > org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258) > Caused by: java.net.BindException: Failed to create server socket on > 192.168.0.4[6379] > at > org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75) > at > org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55) > at > org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522) > at > org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.<init>(AcceptorImpl.java:573) > at > org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291) > at > org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420) > at > org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377) > at > org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039) > at > org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837) > ... 2 more > Caused by: java.net.BindException: Address already in use (Bind failed) > at java.net.PlainSocketImpl.socketBind(Native Method) > at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387) > at java.net.ServerSocket.bind(ServerSocket.java:375) > at > org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72) > ... 10 more > {code} > series of GFSH commands that led to this error: > {code:java} > > start locator > > start server --J=-Dgemfire.geode-for-redis-enabled=true > > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379 > {code} -- This message was sent by Atlassian Jira (v8.20.1#820001)