[
https://issues.apache.org/jira/browse/GEODE-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443900#comment-17443900
]
ASF GitHub Bot commented on GEODE-9324:
---------------------------------------
pdxcodemonkey commented on a change in pull request #812:
URL: https://github.com/apache/geode-native/pull/812#discussion_r749424688
##########
File path: cppcache/integration-test/ThinClientSecurityHelper.hpp
##########
@@ -170,20 +170,20 @@ void initClientAuth(char UserType) {
}
}
-// This putThread class is used in
+// This PutThread class is used in
// testThinClientTracking,testThinClientTicket304, testThinClientTicket317
-class putThread : public ACE_Task_Base {
+class PutThread {
public:
- explicit putThread(std::shared_ptr<Region> r, bool regInt = false,
- int waitTime = 0) {
- m_reg = r;
- m_regInt = regInt;
- m_numthreads = 1;
- m_numops = 0;
- m_isCallBack = false;
- m_sameKey = false;
- m_waitTime = waitTime;
+ explicit PutThread(std::shared_ptr<Region> r, bool regInt = false,
+ int waitTime = 0)
+ : m_reg{r},
Review comment:
Often when refactoring things in a class these days, I will take a few
minutes and rename the member variables to conform to the style guide. Your
call, just would be nice as long as you're in here mucking about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove ACE_Task references
> --------------------------
>
> Key: GEODE-9324
> URL: https://issues.apache.org/jira/browse/GEODE-9324
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS A* native client contributor
> *I WANT TO* remove all remaining references to ACE_Task
> *SO THAT* eventually we can get rid of ACE library
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
