Darrel Schneider created GEODE-9800:
---------------------------------------
Summary: improve radish info maxmemory and used_memory
Key: GEODE-9800
URL: https://issues.apache.org/jira/browse/GEODE-9800
Project: Geode
Issue Type: Improvement
Components: redis
Reporter: Darrel Schneider
Currently the radish INFO command returns values for maxmemory and used_memory
that are not as helpful as they could be.
For maxmemory it returns PartitionedRegion.getLocalMaxMemory. That is just a
hint to geode to help it decide which server should get a new bucket. It in no
ways limits how much data can be stored in the region. But radish also stores
things in the server that do not go in a region (pubsub info). So maxmemory
should instead be equal to java.lang.Runtime.maxMemory().
For used_memory it return dataStore.currentAllocatedMemory(). But that only
shows how much data is stored in the region locally (and is only an estimate of
that) so once again does not account for pubsub or for all the extra overhead
we have in our radish implementation. So instead it should return
Runtime.maxMemory()-Runtime.freeMemory(). Note that Runtime.totalMemory()
should not be used since some jvms set totalMemory to maxMemory. Even when that
is done freeMemory() has a meaningful value so max-free is a good estimate of
"used_memory".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
