[ 
https://issues.apache.org/jira/browse/GEODE-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435645#comment-17435645
 ] 

ASF GitHub Bot commented on GEODE-9291:
---------------------------------------

DonalEvans commented on a change in pull request #159:
URL: https://github.com/apache/geode-benchmarks/pull/159#discussion_r738705681



##########
File path: 
geode-benchmarks/src/main/java/org/apache/geode/benchmark/redis/tests/RedisWeightedZaddAndZrangeBenchmark.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.geode.benchmark.redis.tests;
+
+import static org.apache.geode.benchmark.Config.before;
+import static org.apache.geode.benchmark.Config.workload;
+import static org.apache.geode.benchmark.topology.Roles.CLIENT;
+
+import org.apache.geode.benchmark.redis.tasks.PrePopulateRedisHash;
+import org.apache.geode.benchmark.redis.tasks.ZaddRedisTask;
+import org.apache.geode.benchmark.redis.tasks.ZrangeRedisTask;
+import org.apache.geode.benchmark.tasks.WeightedTasks;
+import org.apache.geode.benchmark.tasks.WeightedTasks.WeightedTask;
+import org.apache.geode.perftest.TestConfig;
+
+public class RedisWeightedZaddAndZrangeBenchmark extends RedisBenchmark {
+
+  @Override
+  public TestConfig configure() {
+    final TestConfig config = super.configure();
+
+    before(config, new PrePopulateRedisHash(redisClientManager, keyRange), 
CLIENT);

Review comment:
       I think this should be `PrePopulateRedisSortedSet()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Develop Benchmarking Tests for Leaderboard API
> ----------------------------------------------
>
>                 Key: GEODE-9291
>                 URL: https://issues.apache.org/jira/browse/GEODE-9291
>             Project: Geode
>          Issue Type: Test
>          Components: redis
>    Affects Versions: 1.15.0
>            Reporter: Wayne
>            Assignee: Eric Zoerner
>            Priority: Major
>              Labels: pull-request-available, redis
>
> Develop a suite of benchmarking tests for the Leaderboard API that benchmark 
> the comparison between native Redis and the compatibility with Redis layer.
> +Acceptance Criteria+
> A benchmark should be developed that provides acceptable coverage (TBD) of 
> the Leaderboard API that allows us to monitor the performance over time and 
> compared to native Redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to