[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430182#comment-17430182 ]
ASF GitHub Bot commented on GEODE-9719: --------------------------------------- pdxcodemonkey commented on a change in pull request #881: URL: https://github.com/apache/geode-native/pull/881#discussion_r731252105 ########## File path: netcore/shared/GfshExecute.cs ########## @@ -28,11 +28,19 @@ public class GfshExecute : Gfsh private String connectionCommand_ = null; private ITestOutputHelper output; - public GfshExecute(ITestOutputHelper output) + public ITestOutputHelper Output { - this.output = output; + get { return output; } + set { output = value; } } + + public GfshExecute(ITestOutputHelper output) + { + //Output = output; + this.output = output; + } Review comment: Looks like you have a tabs vs spaces issue in this file(?). Please fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Switch .NET Core Tests to Xunit Fixtures > ---------------------------------------- > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client > Reporter: Michael Martell > Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.3.4#803005)