[ 
https://issues.apache.org/jira/browse/GEODE-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429153#comment-17429153
 ] 

ASF subversion and git services commented on GEODE-9720:
--------------------------------------------------------

Commit a21df0be14b1c8ac4eed7eeca64777ed35e723e9 in geode's branch 
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a21df0b ]

GEODE-9720: remove *FunctionExecutor classes (#6977)

* The redis "execute*" and "stripedExecute*" methods are now named 
"lockedExecute*".
ExecutionHandlerContext has redis data type aware "lockedExecute" methods.

the RedisDataType enum now knows its corresponding null type
This saves a hashMap lookup on each redis operation

renamed the Executor interface to CommandExecutor
renamed the CommandExecutor class to COMMANDCommandExecutor

Added some singleton RedisResponse instances 

> redis FunctionExecutor classes should be renamed or removed
> -----------------------------------------------------------
>
>                 Key: GEODE-9720
>                 URL: https://issues.apache.org/jira/browse/GEODE-9720
>             Project: Geode
>          Issue Type: Improvement
>          Components: redis
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> the geode-for-redis implementation has a bunch of classes whose name ends 
> with "FunctionExecutor". These used to actually be implemented using geode 
> functions. But now they are just part of the top level command executor and 
> usually deal with locking down the geode primary bucket and obtaining striped 
> locks.
> They should be renamed or removed. Renaming is easier but removal also 
> simplifies the code and makes it easier in the future to add more commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to