[
https://issues.apache.org/jira/browse/GEODE-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428888#comment-17428888
]
ASF GitHub Bot commented on GEODE-9639:
---------------------------------------
mreddington commented on pull request #874:
URL: https://github.com/apache/geode-native/pull/874#issuecomment-943483292
Aren't all the requested changes outside the scope of this PR? I was to make
the library's client interface compatible with C++20. This PR as it stands
accomplishes that. If you want me to go in and remove other cruft, make other
changes to the internal implementation, fine - just make a new JIRA ticket for
it. As it stands, these things you're asking to change don't affect ABI
compatibility with C++20 along the same toolchain, and that has already been
proven. What does affect ABI compatibility is changing toolchains from VS 2017
to VS 2019, which internal changes won't fix, either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make native client compatible with C++20
> ----------------------------------------
>
> Key: GEODE-9639
> URL: https://issues.apache.org/jira/browse/GEODE-9639
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Matthew Reddington
> Priority: Major
> Labels: pull-request-available
>
> There are standard library components that were removed in C++20, making our
> library incompatible. Luckily, our use of deleted components are minimal and
> replaceable without breaking API backward compatibility, but it will disrupt
> ABI compatibility.
>
> The outcome needs to be tested against MSVC2017/v141 and MSVC2019/v142,
> including examples.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
