[ https://issues.apache.org/jira/browse/GEODE-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419094#comment-17419094 ]
Mario Ivanac commented on GEODE-9630: ------------------------------------- Hi, just info, that part of setters was introduced as solution for https://issues.apache.org/jira/browse/GEODE-8605, and introduction of setters was proposal from RFC [https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=165223754.|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=165223754] So this part can not be removed without impacting introduced functionality. BR, Mario > Gateway sender has public setter methods that should not be exposed > ------------------------------------------------------------------- > > Key: GEODE-9630 > URL: https://issues.apache.org/jira/browse/GEODE-9630 > Project: Geode > Issue Type: Improvement > Components: wan > Affects Versions: 1.15.0 > Reporter: Udo Kohlmeyer > Priority: Blocker > Labels: blocks-1.15.0 > > Looking at the GatewaySender interface I noticed there are numerous public > setter methods. Geode should not allow for the ability to directly change > GatewaySender functionality without proper process. > This is largely to avoid the introduction of side effects into the system. A > prime example of this is, the ability to call `setGroupTransactionEvents`, > which from what I understand should NEVER be allowed to be changed in just 1 > server instead of cluster-wide. This by writing a function and changing the > setting on only 1 server can run the risk of the whole system behaving > incorrectly causing failures which would be close to impossible to track down. -- This message was sent by Atlassian Jira (v8.3.4#803005)