[ 
https://issues.apache.org/jira/browse/GEODE-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401861#comment-17401861
 ] 

ASF subversion and git services commented on GEODE-4181:
--------------------------------------------------------

Commit 5e9b3684f2be3f2ff8174c690bd2c15d31f9179c in geode's branch 
refs/heads/develop from Dale Emery
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5e9b368 ]

GEODE-4181: Reduce ChildVM command line length (#6763)

PROBLEM

Windows limits command lines to a maximum length of ~32k characters. The
command line for DUnit child VMs is very close to this limit.

Currently this prevents us from adding JUnit 5 support. JUnit 5 adds 8
more jars to the classpath, which adds ~1300 characters to the command
line, which puts the command line over the limit.

SOLUTION

Write the ChildVM's entire classpath to a "pathing" jar, then include
only that pathing jar on the command line. This results in command line
that is shorter by many thousands of characters, and which does not grow
as we add more jars or other classpath elements.

> Update to JUnit 5.x
> -------------------
>
>                 Key: GEODE-4181
>                 URL: https://issues.apache.org/jira/browse/GEODE-4181
>             Project: Geode
>          Issue Type: Improvement
>          Components: general, tests
>            Reporter: Patrick Rhomberg
>            Assignee: Dale Emery
>            Priority: Major
>              Labels: GeodeOperationAPI, pull-request-available
>
> In addition to the expected benefits that come with new versions, updating to 
> JUnit 5.x should allow us to remove the workaround required in GEODE-1350 / 
> GEODE-4122.
> If migration guides are to be believed, migration from JUnit 4.x to 5.x in 
> and of itself should not be difficult.  However, interaction with Mockito and 
> PowerMock appears to be significantly different and will require 
> investigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to