[ 
https://issues.apache.org/jira/browse/GEODE-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401769#comment-17401769
 ] 

ASF subversion and git services commented on GEODE-9169:
--------------------------------------------------------

Commit ed38145379d3da05ecc79a39fa145030bbd4fb1e in geode's branch 
refs/heads/expireAuthentication from Hale Bales
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ed38145 ]

GEODE-9169: remove netty context switch (#6725)

GEODE-9169: Remove Netty context switch

Instead of submitting commands to a background executor, this removes
that context switch and performs the command right on the netty thread.
Removing the context switch provides a significant performance
improvement.

Signed-off-by: Donal Evans <doev...@vmware.com>

> Remove Context Switch Between Netty and Command Queue Thread
> ------------------------------------------------------------
>
>                 Key: GEODE-9169
>                 URL: https://issues.apache.org/jira/browse/GEODE-9169
>             Project: Geode
>          Issue Type: New Feature
>          Components: redis
>            Reporter: Wayne
>            Assignee: Hale Bales
>            Priority: Major
>              Labels: blocks-1.15.0​, performance, pull-request-available, 
> redis
>             Fix For: 1.15.0
>
>
> On the current develop branch, the Netty thread reads a message and then puts 
> it on a queue for another thread to process. Performing the region update 
> directly on the Netty thread significantly improved performance.
> The original behavior was there to support pub/sub use cases, where we need 
> to push updates to the Netty channel, as well as following Netty best 
> practices of not blocking the Netty thread. We need to see how we can make 
> this same change on develop to avoid the context switch while still 
> supporting pub/sub and not breaking other use cases.
> +Acceptance Criteria+
> The context switch between the Netty and command queue thread has been 
> removed for all commands that are not pub/sub related.
> Geode benchmarks perform better after this change for all non-pubsub commands.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to