[ 
https://issues.apache.org/jira/browse/GEODE-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398272#comment-17398272
 ] 

ASF subversion and git services commented on GEODE-9480:
--------------------------------------------------------

Commit 763493ddd9db97d2d0030c28764e9c1e3fd1fd07 in geode's branch 
refs/heads/support/1.13 from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=763493d ]

GEODE-9480: Changing the version with ordinal 121 to be 1.13.2

This protocol change actually happened in 1.13.2. 1.13.1 is still using the
same protocol ordinal as 1.13.0, which is 120.

Evidence
* b2d205459bf is the commit that introduced this version in support/1.13
* b2d205459bf is only contained in rel/v1.13.2 and above
* Running geode 1.13.1, it reports it's protocol version as 120.

(cherry picked from commit 2a90a583015352c1cc0f041008ec2a6ea7b5505c)

> KnownVersions class has 1.13.1 listed as the version for ordinal 121, but it 
> should be 1.13.2
> ---------------------------------------------------------------------------------------------
>
>                 Key: GEODE-9480
>                 URL: https://issues.apache.org/jira/browse/GEODE-9480
>             Project: Geode
>          Issue Type: Bug
>          Components: core
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>              Labels: blocks-1.14.0​, pull-request-available
>
> KnownVersion.java on develop and Version.java in the support/1.13 branch have 
> 1.13.1 listed as the version in which the protocol ordinal changed to 121. 
> However, 1.13.1 doesn't actually use that ordinal, it reports itself as using 
> protocol ordinal 120 (the same as 1.13.0).
> This file should be changed to indicate that 1.13.2 is actually the version 
> in which the protocol changed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to