[
https://issues.apache.org/jira/browse/GEODE-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398137#comment-17398137
]
ASF GitHub Bot commented on GEODE-9487:
---------------------------------------
pdxcodemonkey merged pull request #838:
URL: https://github.com/apache/geode-native/pull/838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timezone is potentially invalid string in log files for non-English locales
> ----------------------------------------------------------------------------
>
> Key: GEODE-9487
> URL: https://issues.apache.org/jira/browse/GEODE-9487
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Assignee: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> The native client logger was rewritten several months ago to use, among other
> things, `std::put_time` when formatting log strings, specifically using the
> "%Z" formatting for timezone. The documentation for this formatting says
> "writes locale-dependent time zone name or abbreviation, or no characters if
> the time zone information is not available," and indeed it does. We just
> received a log file from a customer machine in APJ region, i.e. locale is set
> to something like Traditional Chinese. These strings are dumped into the log
> file as is, in some unknown MBCS encoding, and contain invalid utf-8 start
> codes, throwing off our Python-based parsing tool.
> We should probably just drop time zone from our logs, or normalize everything
> somehow. In any case, we need to write valid utf-8, just to play well with
> others.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
