[
https://issues.apache.org/jira/browse/GEODE-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396851#comment-17396851
]
ASF subversion and git services commented on GEODE-9483:
--------------------------------------------------------
Commit 5a6fe75d6c8142613cf210f9702c491e2162c8a6 in geode's branch
refs/heads/develop from Dale Emery
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5a6fe75 ]
GEODE-9483: Make StartLocatorCommandIntegrationTest not start unneeded locator
(#6731)
Two of the tests in `StartLocatorCommandIntegrationTest` launch a locator
process that binds to the default HTTP service port (7070). This can
interfere with the tests that explicitly verify that the system uses the
correct HTTP service port by default.
Neither test actually needs the launched locator for any purpose.
Neither test makes a single assertion about the locator. When the tests
exit, they leave the locator running. In fact, the locator typically
finishes launching well after the tests have all exited.
Rather than fix the port assignment, this commit changes the tests so
that they do not actually launch a locator. Two of the tests in this
class already do this.
> StartLocatorCommandIntegrationTest creates unnecessary processes and leaves
> them running
> ----------------------------------------------------------------------------------------
>
> Key: GEODE-9483
> URL: https://issues.apache.org/jira/browse/GEODE-9483
> Project: Geode
> Issue Type: Test
> Components: tests
> Reporter: Dale Emery
> Assignee: Dale Emery
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> Two of the tests in {{StartLocatorCommandIntegrationTest}} launch a locator
> process that binds to the default HTTP service port (7070). Tests should not
> use the default port for any service.
> Neither test actually needs the launched locator for any purpose. Neither
> test makes a single assertion about the locator. When the tests exit, they
> leave the locator running. In fact, the locator typically finishes launching
> well after the tests have all exited.
> Rather than fix the port assignment, we should instead change the tests so
> that they do not actually launch a locator. Two of the tests in this class
> already do this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
