[
https://issues.apache.org/jira/browse/GEODE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372941#comment-17372941
]
ASF GitHub Bot commented on GEODE-9405:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #826:
URL: https://github.com/apache/geode-native/pull/826#discussion_r662460657
##########
File path: cppcache/integration-test/ThinClientSecurityHelper.hpp
##########
@@ -59,13 +59,15 @@ const char* regionNamesAuth[] = {"DistRegionAck"};
std::shared_ptr<CredentialGenerator> credentialGeneratorHandler;
std::string getXmlPath() {
- char xmlPath[1000] = {'\0'};
- const char* path = std::getenv("TESTSRC");
- ASSERT(path != nullptr,
+ std::string path = std::string(std::getenv("TESTSRC"));
Review comment:
Oh yes, good catch!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build fails on rhel-8 release
> -----------------------------
>
> Key: GEODE-9405
> URL: https://issues.apache.org/jira/browse/GEODE-9405
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> Looks like a recent gcc compiler change on rhel-8 is causing build failures
> in the CI.
> Looks to be related to unsafe use of strncpy in a few of our legacy C++ tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
