[jira] [Commented] (GEODE-9268) Fix coredump whenever getFieldNames is called after a cluster restart

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/GEODE-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372657#comment-17372657
 ] 

ASF GitHub Bot commented on GEODE-9268:
---------------------------------------

gaussianrecurrence commented on a change in pull request #806:
URL: https://github.com/apache/geode-native/pull/806#discussion_r662179040



##########
File path: cppcache/src/PdxHelper.cpp
##########
@@ -175,61 +163,59 @@ std::shared_ptr<PdxSerializable> 
PdxHelper::deserializePdx(DataInput& dataInput,
   auto pType = pdxTypeRegistry->getPdxType(typeId);
   if (pType) {
     // this may happen with PdxInstanceFactory
-    pdxLocalType = pdxTypeRegistry->getLocalPdxType(pType->getPdxClassName());
+    localType = pdxTypeRegistry->getLocalPdxType(pType->getPdxClassName());
   }
-  if (pType && pdxLocalType) {
+  if (pType && localType) {
     // type found
     auto&& pdxClassname = pType->getPdxClassName();
     LOGDEBUG("deserializePdx ClassName = " + pdxClassname +
              ", isLocal = " + std::to_string(pType->isLocal()));
 
-    pdxObjectptr = serializationRegistry->getPdxSerializableType(pdxClassname);
+    object = serializationRegistry->getPdxSerializableType(pdxClassname);
     if (pType->isLocal())  // local type no need to read Unread data
     {
       auto plr = PdxLocalReader(dataInput, pType, length, pdxTypeRegistry);
-      pdxObjectptr->fromData(plr);
+      object->fromData(plr);
       plr.moveStream();
     } else {
       auto prr = PdxRemoteReader(dataInput, pType, length, pdxTypeRegistry);
-      pdxObjectptr->fromData(prr);
+      object->fromData(prr);
       auto mergedVersion = pdxTypeRegistry->getMergedType(pType->getTypeId());
 
-      auto preserveData = prr.getPreservedData(mergedVersion, pdxObjectptr);
+      auto preserveData = prr.getPreservedData(mergedVersion, object);
       if (preserveData != nullptr) {
         pdxTypeRegistry->setPreserveData(
-            pdxObjectptr, preserveData,
+            object, preserveData,
             cacheImpl
                 ->getExpiryTaskManager());  // it will set data in weakhashmap
       }
       prr.moveStream();
 
-      if (auto pdxWrapper =
-              std::dynamic_pointer_cast<PdxWrapper>(pdxObjectptr)) {
-        if (!pdxWrapper->getObject()) {
+      if (auto wrapper = std::dynamic_pointer_cast<PdxWrapper>(object)) {
+        if (!wrapper->getObject()) {
           // No serializer was registered to deserialize this type.
           // Fall back to PdxInstance
           return nullptr;
         }
       }
     }
   } else {
-    // type not found; need to get from server
-    if (!pType) {
+    if (pType == nullptr) {

Review comment:
       Indeed, sorry I try to leave aside my coding conventions hehe, but 
sometimes I don't notice. Will change it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix coredump whenever getFieldNames is called after a cluster restart
> ---------------------------------------------------------------------
>
>                 Key: GEODE-9268
>                 URL: https://issues.apache.org/jira/browse/GEODE-9268
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Mario Salazar de Torres
>            Assignee: Mario Salazar de Torres
>            Priority: Major
>              Labels: pull-request-available
>
> *WHEN* A PdxInstance is fetched from a region
>  *AND* The whole cluster is restarted, triggering PdxTypeRegistry cleanup.
>  *AND* getFieldNames is called on the PdxInstance created just before
>  *THEN* a coredump happens.
> —
> *Additional information:*
> Callstack:
> {noformat}
> [ERROR 2021/05/05 12:57:12.781834 CEST main (139683590957120)] Segmentation 
> fault happened
>  0# handler(int) at nc-pdx/main.cpp:225
>  1# 0x00007F0A9F5F13C0 in /lib/x86_64-linux-gnu/libpthread.so.0
>  2# apache::geode::client::PdxType::getPdxFieldTypes() const at 
> cppcache/src/PdxType.hpp:181
>  3# apache::geode::client::PdxInstanceImpl::getFieldNames() at 
> cppcache/src/PdxInstanceImpl.cpp:1383
>  4# main at nc-pdx/main.cpp:374
>  5# __libc_start_main in /lib/x86_64-linux-gnu/libc.so.6
>  6# _start in build/pdx{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)