[
https://issues.apache.org/jira/browse/GEODE-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353528#comment-17353528
]
ASF GitHub Bot commented on GEODE-9110:
---------------------------------------
mreddington commented on a change in pull request #805:
URL: https://github.com/apache/geode-native/pull/805#discussion_r641766995
##########
File path: cppcache/integration/test/HARegionCacheListenerARLEPDTest.cpp
##########
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <framework/Cluster.h>
+#include <framework/Framework.h>
+#include <framework/Gfsh.h>
+#include <gmock/gmock.h>
+
+#include <future>
+#include <iostream>
+#include <random>
+#include <thread>
+
+#include <boost/log/core.hpp>
+
+#include <gtest/gtest.h>
+
+#include <geode/AttributesMutator.hpp>
+#include <geode/Cache.hpp>
+#include <geode/CacheListener.hpp>
+#include <geode/EntryEvent.hpp>
+#include <geode/PoolManager.hpp>
+#include <geode/RegionEvent.hpp>
+#include <geode/RegionFactory.hpp>
+#include <geode/RegionShortcut.hpp>
+
+#include "mock/CacheListenerMock.hpp"
+
+namespace {
+// Until we get C++14 support...
+template <typename T, typename... Args>
+::std::unique_ptr<T> make_unique(Args &&... args) {
+ return ::std::unique_ptr<T>(new T(::std::forward<Args>(args)...));
+}
+
+// A simple comparator for cachables wrapped in shared pointers.
+// MATCHER_P(CashableEq, value, "") {
+// return arg->toString() == value->toString();
+// }
+
+class HARegionCacheListenerARLEPDTest : public ::testing::Test {
Review comment:
AfterRegionLiveEndPointDisconnected. As you can see, I haven't figured
out how to get a grip on naming tests. The test cases are beautifully simple
and easy to understand, but to retain context of just what the preconditions
are being tested against, the names are getting huge. I'm very open to
suggestions because I don't like what's going on, either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port "important" disabled legacy tests to new framework and enable
> ------------------------------------------------------------------
>
> Key: GEODE-9110
> URL: https://issues.apache.org/jira/browse/GEODE-9110
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> After scouring through the code for the disabled legacy tests, we've
> identified the following list of 31 tests that look important enough to have
> running in the new framework:
> testThinClientAfterRegionLive
> testThinClientCq
> testThinClientDurableDisconnectNormal
> testThinClientDurableDisconnectTimeout
> testThinClientDurableReconnect
> testThinClientHAMixedRedundancy
> testThinClientHAQueryFailover
> testThinClientLRUExpiration
> testThinClientLargePutAllWithCallBackArg
> testThinClientLocatorFailover
> testThinClientPartitionResolver
> testThinClientPdxDeltaWithNotification
> testThinClientPdxTests
> testThinClientPutAll
> testThinClientSecurityCQAuthorizationMU
> testThinClientTXFailover
> testTimedSemaphore
> testThinClientCqDurable
> testThinClientRemoveOps
> testThinClientSecurityAuthentication
> testThinClientSecurityAuthenticationMU
> testThinClientSecurityAuthorization
> testThinClientSecurityAuthorizationMU
> testThinClientSecurityDurableCQAuthorizationMU
> testThinClientSecurityPostAuthorization
> testThinClientTicket303
> testThinClientTicket304
> testThinClientTracking
> testThinClientWriterException
>
> When you port a test, submit a PR against this issue, and strike out the test
> name in the list so we know it's done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
