[
https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352703#comment-17352703
]
ASF subversion and git services commented on GEODE-9078:
--------------------------------------------------------
Commit 76615158194c51a4ccace652f1f93f4571c83c67 in geode-native's branch
refs/heads/develop from Mario Salazar de Torres
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=7661515 ]
GEODE-9078: Remove ACE mutexes (#776)
- Removed all ACE mutexes.
- Solved header inclusion leak in order to avoid linking Boost to
testobject.
- TODO. Review mutex usage in PdxType as it is only used to read, so
either it's not necessary or we are missing write locks.
- Removed testTimedSemaphore old ITs as ACE_Semaphore is not used
anymore.
- Changed member variable naming to the current standard for
AdminRegion class.
- Got rid of TryReadGuard and TryWriteGuard as it's not really
necessary. Code has been refactored so it uses plain shared_mutex
instead.
- shared_mutex from AdminRegion, RemoteQueryService and
ThinClientRegion are not publicly exposed anymore. For correctness,
locks are exposed instead.
- Reverted naming change on member variables for class AdminRegion.
- Fixed exception in .Net integration tests. An exception with message
"The string binding is invalid" was being thrown due to the fact that
the Apache.Geode DLL has mixed code and compiles with CLR enabled.
That's something dis-recommended by Boost because under certain
conditions could cause problems with boost static variables.
In this case the issue was related to one of the boost::exception
static variables.
This issue was solved by removing header inclusion introduced in
revision 3.
- Due to above issue, exposing the lock rather than the mutex is not
possible for now, until a further refactor is made to .Net code, so
mutex/lock exposition from revision 3 has been reverted.
- As it was determined, there is no need to guarantee exclusive access
to PdxTypes, so both remains of shared_lock are removed.
- Also, removed ReadWriteLock, as it's not necessary anymore.
> Remove ACE mutexes
> ------------------
>
> Key: GEODE-9078
> URL: https://issues.apache.org/jira/browse/GEODE-9078
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS AN* geode-native contributor
> *I WANT TO* remove all occurrences of ACE mutexes
> *SO THAT* we can get rid of ACE for good
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
