Lynn Gallinat created GEODE-9124:
------------------------------------

             Summary: 
org.apache.geode.management.internal.function.RebalanceFunction logging needs 
improvement
                 Key: GEODE-9124
                 URL: https://issues.apache.org/jira/browse/GEODE-9124
             Project: Geode
          Issue Type: Bug
          Components: functions
    Affects Versions: 1.15.0
            Reporter: Lynn Gallinat


The output from the RebalanceFunction is confusing. Two "Starting 
RebalanceFunction..." messages are logged.

The first logged message provides results from the rebalance implying it's 
complete, then we log a second time saying rebalance is starting.

Starting RebalanceFunction got results = \{totalBucketCreateBytes=0, 
totalBucketCreateTimeInMilliseconds=0, totalBucketCreatesCompleted=0, 
totalBucketTransferBytes=163831, totalBucketTransferTimeInMilliseconds=2836, 
totalBucketTransfersCompleted=85, totalPrimaryTransferTimeInMilliseconds=139, 
totalPrimaryTransfersCompleted=5, totalTimeInMilliseconds=3301, 
totalNumOfMembers=7}

Starting RebalanceFunction str1=0,0,0,163831,2836,85,139,5,3301,7,/testRegion

 

By the time both of these are logged rebalance is in fact completed so it 
shouldn't say "Starting..."

 
{code:java}
    if (simulate.equals("true")) {
      op = rbFactory.simulate();
    } else {
      op = rbFactory.start();    <======= starting
    }

    try {
      results = op.getResults();    <======== completed
      logger.info("Starting RebalanceFunction got results = {}", results);
      StringBuilder str1 = new StringBuilder();
      str1.append(results.getTotalBucketCreateBytes()).append(",")
          .append(results.getTotalBucketCreateTime()).append(",")
          .append(results.getTotalBucketCreatesCompleted()).append(",")
          .append(results.getTotalBucketTransferBytes()).append(",")
          .append(results.getTotalBucketTransferTime()).append(",")
          .append(results.getTotalBucketTransfersCompleted()).append(",")
          .append(results.getTotalPrimaryTransferTime()).append(",")
          .append(results.getTotalPrimaryTransfersCompleted()).append(",")
          
.append(results.getTotalTime()).append(",").append(results.getTotalMembersExecutedOn())
          .append(",").append(String.join(",", includeRegionNames));

      logger.info("Starting RebalanceFunction str1={}", str1);
      context.getResultSender().lastResult(str1.toString());
{code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to