[
https://issues.apache.org/jira/browse/GEODE-9108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314975#comment-17314975
]
ASF GitHub Bot commented on GEODE-9108:
---------------------------------------
mmartell commented on a change in pull request #780:
URL: https://github.com/apache/geode-native/pull/780#discussion_r607208728
##########
File path: cppcache/integration-test/ThinClientHelper.hpp
##########
@@ -134,7 +134,7 @@ const char* vals[] = {"Value-1", "Value-2", "Value-3",
const char* nvals[] = {"New Value-1", "New Value-2", "New Value-3",
"New Value-4", "New Value-5", "New Value-6"};
-const char* regionNames[] = {"DistRegionAck", "DistRegionNoAck"};
+const char* regionNames[] = {"DistRegionAck", "not-used"};
Review comment:
Lots of tests use this header. Changing to a scalar caused lots of
compile issues (mostly in disabled tests). Suggest we leave this file
untouched, as probably too much work to fix compile issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove no-ack from existing tests
> ---------------------------------
>
> Key: GEODE-9108
> URL: https://issues.apache.org/jira/browse/GEODE-9108
> Project: Geode
> Issue Type: Test
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> Many of the geode-native legacy tests use no-ack for the region scope
> attribute. This has been shown to be the source of intermittent failures of
> many of the tests, and should should be removed. As region scope is purely
> server side functionality, there should little to no need to test it from a
> client's perspective. If there is a use case for such a no-ack test from
> geode-native, it should be captured in a new test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
