[
https://issues.apache.org/jira/browse/GEODE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307993#comment-17307993
]
ASF GitHub Bot commented on GEODE-9058:
---------------------------------------
gaussianrecurrence commented on a change in pull request #774:
URL: https://github.com/apache/geode-native/pull/774#discussion_r600665284
##########
File path: cppcache/src/DistributedSystemImpl.cpp
##########
@@ -81,9 +81,9 @@ void DistributedSystemImpl::logSystemInformation() const {
ACE_utsname u;
ACE_OS::uname(&u);
- LOGCONFIG(
- "Running on: SystemName=%s Machine=%s Host=%s Release=%s Version=%s",
- u.sysname, u.machine, u.nodename, u.release, u.version);
+ LOGCONFIG("Running on: SystemName=" BOOST_PLATFORM
Review comment:
You've got a point. I did not want to change the output, but it's true
that this kind of info is not much relevant and if needed for troubleshooting
it can be asked to the issue reporter. If you are OK with removing the call it
would make my life a whole lot more easy and future code more maintable. What
you think @pivotal-jbarrett ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove ACE_OS references
> ------------------------
>
> Key: GEODE-9058
> URL: https://issues.apache.org/jira/browse/GEODE-9058
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS A* geode-native contributor
> *I WOULD LIKE* to remove any references to ACE_OS in the source
> *SO THAT* we can get rid of ACE for good, eventually.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
