[ https://issues.apache.org/jira/browse/GEODE-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298296#comment-17298296 ]
ASF GitHub Bot commented on GEODE-9016: --------------------------------------- kirklund commented on a change in pull request #6104: URL: https://github.com/apache/geode/pull/6104#discussion_r590674686 ########## File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/dunit/PartitionedRegionCqQueryDUnitTest.java ########## @@ -120,6 +123,60 @@ private static int bridgeServerPort; + @Test + public void testPutAllWithCQLocalDestroy() throws Exception { + VM server1 = getVM(0); + VM server2 = getVM(1); + VM client = getVM(2); + + final String cqName = "testPutAllWithCQLocalDestroy_0"; + createServer(server1); + createServer(server2); + final String host = Host.getHost(0).getHostName(); + final int port = server2.invoke(() -> PartitionedRegionCqQueryDUnitTest.getCacheServerPort()); + createClient(client, port, host); + createCQ(client, cqName, cqs[0]); + + int numObjects = 1000; + + server1.invoke(() -> { + Region region = getCache().getRegion(SEPARATOR + "root" + SEPARATOR + regions[0]); + Map buffer = new HashMap(); Review comment: PS: You don't really need `SEPARATOR + "root" + SEPARATOR`. This will also work: ``` getCache().getRegion(regions[0]); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NullPointerException during PutAll with CQ LOCAL_DESTROY event > -------------------------------------------------------------- > > Key: GEODE-9016 > URL: https://issues.apache.org/jira/browse/GEODE-9016 > Project: Geode > Issue Type: Bug > Reporter: Jianxia Chen > Assignee: Jianxia Chen > Priority: Major > Labels: pull-request-available > > It is possible that PutAll operation hits a NPE when CQ LOCAL_DESTROY event > is generated. > {code:java} > java.lang.NullPointerException > at > java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936) > at > org.apache.geode.cache.query.cq.internal.ServerCQResultsCachePartitionRegionImpl.remove(ServerCQResultsCachePartitionRegionImpl.java:69) > at > org.apache.geode.cache.query.cq.internal.ServerCQImpl.removeFromCqResultKeys(ServerCQImpl.java:297) > at > org.apache.geode.internal.cache.DistributedCacheOperation.removeDestroyTokensFromCqResultKeys(DistributedCacheOperation.java:743) > at > org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:693) > at > org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277) > at > org.apache.geode.internal.cache.DistributedRegion.postPutAllSend(DistributedRegion.java:3304) > at > org.apache.geode.internal.cache.LocalRegionDataView.postPutAll(LocalRegionDataView.java:358) > at > org.apache.geode.internal.cache.partitioned.PutAllPRMessage.doPostPutAll(PutAllPRMessage.java:568) > at > org.apache.geode.internal.cache.partitioned.PutAllPRMessage.doLocalPutAll(PutAllPRMessage.java:507) > at > org.apache.geode.internal.cache.partitioned.PutAllPRMessage.operateOnPartitionedRegion(PutAllPRMessage.java:326) > at > org.apache.geode.internal.cache.partitioned.PartitionMessage.process(PartitionMessage.java:333) > at > org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376) > at > org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:440) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at > org.apache.geode.distributed.internal.ClusterOperationExecutors.runUntilShutdown(ClusterOperationExecutors.java:442) > at > org.apache.geode.distributed.internal.ClusterOperationExecutors.doPartitionRegionThread(ClusterOperationExecutors.java:422) > at > org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:119) > at java.lang.Thread.run(Thread.java:748) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)