[
https://issues.apache.org/jira/browse/GEODE-8965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297400#comment-17297400
]
ASF GitHub Bot commented on GEODE-8965:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #6085:
URL: https://github.com/apache/geode/pull/6085#discussion_r589454801
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/netty/Coder.java
##########
@@ -278,6 +281,16 @@ public static ByteBuf getErrorResponse(ByteBufAllocator
alloc, String error) {
return response;
}
+ public static ByteBuf getOOMResponse(ByteBufAllocator alloc, String error) {
+ byte[] errorAr = stringToBytes(error);
+ ByteBuf response = alloc.buffer(errorAr.length + 25);
Review comment:
This is inherited from the original author(s) and we don't know what
this is for. We've also found excessive (and unnecessary) allocations in this
class which will shortly be corrected. That change will also remove these weird
constants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement Redis "noevict" policy for Geode Redis
> ------------------------------------------------
>
> Key: GEODE-8965
> URL: https://issues.apache.org/jira/browse/GEODE-8965
> Project: Geode
> Issue Type: New Feature
> Components: redis
> Reporter: Raymond Ingles
> Assignee: Raymond Ingles
> Priority: Major
> Labels: blocks-1.14.0, pull-request-available
>
> Redis supports the "noevict" eviction policy. When this is selected, Redis
> returns an OOM error when commands that consume new memory are attempted. New
> data cannot be written to the cache until either TTL expiration or explicit
> deletion of keys has freed enough memory to allow write operations again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
