[ 
https://issues.apache.org/jira/browse/GEODE-8943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296380#comment-17296380
 ] 

ASF GitHub Bot commented on GEODE-8943:
---------------------------------------

kirklund commented on a change in pull request #6075:
URL: https://github.com/apache/geode/pull/6075#discussion_r588765317



##########
File path: 
geode-core/src/test/java/org/apache/geode/internal/cache/FilterProfileTest.java
##########
@@ -1,258 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
- * agreements. See the NOTICE file distributed with this work for additional 
information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the 
License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software 
distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
- * or implied. See the License for the specific language governing permissions 
and limitations under
- * the License.
- */
-package org.apache.geode.internal.cache;
-
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.mockito.Mockito.doNothing;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.spy;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
-import java.util.Collections;
-
-import org.junit.Before;
-import org.junit.Test;
-
-import org.apache.geode.cache.CacheEvent;
-import org.apache.geode.cache.Operation;
-import org.apache.geode.cache.query.internal.cq.CqService;
-
-public class FilterProfileTest {

Review comment:
       Do you really need to delete the `FilterProfileTest`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Filterrs (Interest and CQ) is processed multiple times with transactional 
> operation on PR
> -----------------------------------------------------------------------------------------
>
>                 Key: GEODE-8943
>                 URL: https://issues.apache.org/jira/browse/GEODE-8943
>             Project: Geode
>          Issue Type: Bug
>          Components: cq, regions
>    Affects Versions: 1.14.0
>            Reporter: Anilkumar Gingade
>            Assignee: Eric Shu
>            Priority: Major
>              Labels: blocks-1.14.0​, pull-request-available
>
> The Filters (interest and CQ) could be getting processed multiple times when 
> transactional operation is performed.
> By design on PR the filters are processed on primary bucket where the data is 
> applied/changed and adjunct message with interested clients are sent to 
> remote servers (where the subscription queues are hosted) and replicas; thus 
> performing filter processing once and sending the message to remote servers 
> only if the filters are satisfied; it looks like currently the filter 
> processing is happening both at the primary and secondary buckets for TX 
> operation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to