[
https://issues.apache.org/jira/browse/GEODE-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295618#comment-17295618
]
ASF GitHub Bot commented on GEODE-9003:
---------------------------------------
jchen21 commented on a change in pull request #6093:
URL: https://github.com/apache/geode/pull/6093#discussion_r587885015
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/PersistenceAdvisorImpl.java
##########
@@ -533,7 +535,8 @@ public boolean
checkMyStateOnMembers(Set<InternalDistributedMember> replicates)
String message = String.format(
"Region %s remote member %s with persistent data %s was not part
of the same distributed system as the local data from %s",
regionPath, member, remoteId, myId);
- throw new ConflictingPersistentDataException(message);
+ logger.warn(message);
+ iterator.remove();
Review comment:
Is synchronization neededhere? The `stateOnPeers` maybe shared with
other threads.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/PersistenceAdvisorImpl.java
##########
@@ -533,7 +535,8 @@ public boolean
checkMyStateOnMembers(Set<InternalDistributedMember> replicates)
String message = String.format(
"Region %s remote member %s with persistent data %s was not part
of the same distributed system as the local data from %s",
regionPath, member, remoteId, myId);
- throw new ConflictingPersistentDataException(message);
+ logger.warn(message);
Review comment:
How about `logger.error(message)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove the member from replicates as GII candidate if it's not part of the
> same distributed system
> --------------------------------------------------------------------------------------------------
>
> Key: GEODE-9003
> URL: https://issues.apache.org/jira/browse/GEODE-9003
> Project: Geode
> Issue Type: Bug
> Reporter: Xiaojian Zhou
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
