[
https://issues.apache.org/jira/browse/GEODE-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295590#comment-17295590
]
ASF GitHub Bot commented on GEODE-7309:
---------------------------------------
mkevo commented on a change in pull request #6076:
URL: https://github.com/apache/geode/pull/6076#discussion_r587841824
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/InternalCacheForClientAccess.java
##########
@@ -1225,6 +1226,14 @@ public void unlockDiskStore(String diskStoreName) {
}
+ @Override
+ public boolean hasMemberOlderThan(KnownVersion version) {
+ return getMembers().stream()
Review comment:
Thanks for the suggestion!
As both `GemFireCacheImpl` and `InternalCacheForClientAccess` implements
`InternalCache`, I think that we need to add method body in both classes.
##########
File path:
geode-lucene/src/upgradeTest/java/org/apache/geode/cache/lucene/RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated.java
##########
@@ -31,6 +32,7 @@
public class
RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated
extends LuceneSearchWithRollingUpgradeDUnit {
+ @Ignore
Review comment:
Upgrading to the Lucene 7.1.0 this test is not supported as formatting
is changed between versions. In that case we add note to the documentation so
all cluster members must be on the same version in order to execute Lucene
queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Lucene from 6.6.2 to 8.2.0
> ----------------------------------
>
> Key: GEODE-7309
> URL: https://issues.apache.org/jira/browse/GEODE-7309
> Project: Geode
> Issue Type: Sub-task
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
