[
https://issues.apache.org/jira/browse/GEODE-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295424#comment-17295424
]
ASF GitHub Bot commented on GEODE-8972:
---------------------------------------
kamilla1201 opened a new pull request #6089:
URL: https://github.com/apache/geode/pull/6089
(cherry picked from commit 83e2ee1f167e62721bc4998f834776b49b946b31)
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> remove shunnedMembers collection from GMSMembership
> ---------------------------------------------------
>
> Key: GEODE-8972
> URL: https://issues.apache.org/jira/browse/GEODE-8972
> Project: Geode
> Issue Type: Improvement
> Components: membership
> Reporter: Bruce J Schuchardt
> Assignee: Kamilla Aslami
> Priority: Major
>
> GMSMembership has a _shunnedMembers_ collection that is used to track the IDs
> of nodes that are no longer part of the cluster. This collection is no
> longer needed since we can tell if a node is old by comparing the view ID in
> its identifier to that of the current view (called _latestView_ in that
> class. Checks like this are already in place in some parts of the code.
> All uses of _shunnedMembers_ should be replaced with this check.
> MembershipView<ID> view = latestView;
> boolean shunned = memberId.getVmViewId() <= view.getViewId() &&
> !view.contains(memberId);
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
