[
https://issues.apache.org/jira/browse/GEODE-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295331#comment-17295331
]
ASF GitHub Bot commented on GEODE-8864:
---------------------------------------
sabbey37 commented on a change in pull request #5954:
URL: https://github.com/apache/geode/pull/5954#discussion_r587553014
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/CommandFunction.java
##########
@@ -257,11 +258,13 @@ protected Object compute(ByteArrayWrapper key, Object[]
args) {
case HSCAN: {
Pattern pattern = (Pattern) args[1];
int count = (int) args[2];
- BigInteger cursor = (BigInteger) args[3];
- return hashCommands.hscan(key, pattern, count, cursor);
+ int cursor = Integer.valueOf(args[3].toString());
Review comment:
`args` are an array of Objects (`Object[]`), not strings. `args[3]` can
be cast in the same way that we cast `args[2]` for the `count` variable on the
line above it and throughout the `CommandFunction` class:
```
int cursor = (int) args[3];
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> finish implementation of Redis HScan Command
> --------------------------------------------
>
> Key: GEODE-8864
> URL: https://issues.apache.org/jira/browse/GEODE-8864
> Project: Geode
> Issue Type: New Feature
> Components: redis
> Reporter: John Hutchison
> Priority: Major
> Labels: blocks-1.14.0, pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
