[
https://issues.apache.org/jira/browse/GEODE-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290246#comment-17290246
]
ASF GitHub Bot commented on GEODE-8958:
---------------------------------------
agingade commented on a change in pull request #6042:
URL: https://github.com/apache/geode/pull/6042#discussion_r582281070
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java
##########
@@ -423,8 +425,8 @@ protected void updateStatistics() {
}
@Override
- protected boolean hasExpired(long msTillHeadTombstoneExpires) {
- return msTillHeadTombstoneExpires <= 0;
+ protected boolean hasExpired(long msUntilTombstoneExpires) {
+ return msUntilTombstoneExpires <= 0;
Review comment:
We may have to add the large clock jump verification here too...I am
assuming clients are also doing Tombstone GC similarly....Nice to add a test on
the client side to verify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Tombstone expiration: in the event that a version timestamp is too far in the
> future, expire the tombstone
> ----------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8958
> URL: https://issues.apache.org/jira/browse/GEODE-8958
> Project: Geode
> Issue Type: Bug
> Components: core
> Reporter: Mark Hanson
> Assignee: Mark Hanson
> Priority: Major
> Labels: pull-request-available
>
> We are seeing a bug where for some reason, the version timestamp on the
> tombstone is too far into the future to be realistic.
>
> In such a case, we are going to expire the tombstone as soon as we see it.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
