[ https://issues.apache.org/jira/browse/GEODE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289212#comment-17289212 ]
ASF subversion and git services commented on GEODE-8894: -------------------------------------------------------- Commit 3a21c2852746f19755ac302f584ca5b8908eae2e in geode's branch refs/heads/develop from Ray Ingles [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3a21c28 ] GEODE-8894 allow individual deltas to trigger bucket size recalculation (#5978) * add interface for forcing size recalculation on buckets * Allow individual deltas to trigger bucket size recalculation * remove all deprecated methods and redundant tests * update Javadoc and remove Event instance variable * add EntryEventImpl unit tests for size recalc * remove unused classes/code * remove unused TestKey * reorganize and clarify region creation Co-authored-by: Ray Ingles <ring...@vmware.com> > Allow individual deltas to trigger bucket size recalculation > ------------------------------------------------------------ > > Key: GEODE-8894 > URL: https://issues.apache.org/jira/browse/GEODE-8894 > Project: Geode > Issue Type: New Feature > Components: core, serialization > Affects Versions: 1.14.0 > Reporter: Raymond Ingles > Priority: Major > Labels: pull-request-available > > The Redis subsystem uses Deltas heavily, but by default deltas do not trigger > an update to the size of their buckets. This leads to incorrect memory usage > accounting over the long term, especially with the use of Redis commands like > "APPEND". > It is possible to set the system property "DELTAS_RECALCULATE_SIZE", but this > is a global value that would affect the processing of all deltas, including > non-Redis operations. > Instead, we will add a new default method to the Delta interface, that can be > overridden by individual Delta implementations (such as Redis). This will > trigger the same behavior as DELTAS_RECALCULATE_SIZE, but on a per-delta > basis. Thus, other Geode operations will not force bucket size recalculations > unless the global property is set, but Redis statistics will be correct. > Other types of delta operations may find this useful in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)