[
https://issues.apache.org/jira/browse/GEODE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282141#comment-17282141
]
ASF GitHub Bot commented on GEODE-8894:
---------------------------------------
kirklund commented on a change in pull request #5978:
URL: https://github.com/apache/geode/pull/5978#discussion_r573360097
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/EntryEventImpl.java
##########
@@ -1713,10 +1713,11 @@ private void setNewValueInRegion(final InternalRegion
owner, final RegionEntry r
// This is a horrible hack, but we need to get the size of the object
// When we store an entry. This code is only used when we do a put
// in the primary.
- if (v instanceof org.apache.geode.Delta &&
getRegion().isUsedForPartitionedRegionBucket()) {
+ if (v instanceof Delta && getRegion().isUsedForPartitionedRegionBucket()) {
int vSize;
Object ov = basicGetOldValue();
- if (ov instanceof CachedDeserializable &&
!GemFireCacheImpl.DELTAS_RECALCULATE_SIZE) {
+ if (ov instanceof CachedDeserializable &&
!(GemFireCacheImpl.DELTAS_RECALCULATE_SIZE
Review comment:
If you're looking for ideas on how to get started, one basic technique
from Working Effectively with Legacy Code is to extract your conditional as a
method (static or non-static) and provide unit tests for that new method:
```
@VisibleForTesting
static boolean shouldRecalculateSize(Delta deltaValue) {
return GemFireCacheImpl.DELTAS_RECALCULATE_SIZE ||
deltaValue.getForceRecalculateSize();
}
```
And use it inline where you need to change the behavior (note this could use
a LOT more cleanup but this is a start so you can start with unit test
coverage):
```
if (ov instanceof CachedDeserializable &&
!shouldRecalculateSize((Delta)v)) {
```
And now some unit test coverage:
```
@Test
public void
shouldRecalculateSize_returnsTrue_ifDELTAS_RECALCULATE_SIZEisTrue() {
GemFireCacheImpl.DELTAS_RECALCULATE_SIZE = true;
Delta deltaValue = mock(Delta.class);
when(deltaValue.getForceRecalculateSize())
.thenReturn(false);
boolean value = EntryEventImpl.shouldRecalculateSize(deltaValue);
assertThat(value).isTrue();
}
@Test
public void
shouldRecalculateSize_returnsFalse_ifDELTAS_RECALCULATE_SIZEisFalse() {
GemFireCacheImpl.DELTAS_RECALCULATE_SIZE = false;
Delta deltaValue = mock(Delta.class);
when(deltaValue.getForceRecalculateSize())
.thenReturn(false);
boolean value = EntryEventImpl.shouldRecalculateSize(deltaValue);
assertThat(value).isFalse();
}
@Test
public void
shouldRecalculateSize_returnsTrue_ifGetForceRecalculateSizeIsTrue() {
GemFireCacheImpl.DELTAS_RECALCULATE_SIZE = false;
Delta deltaValue = mock(Delta.class);
when(deltaValue.getForceRecalculateSize())
.thenReturn(true);
boolean value = EntryEventImpl.shouldRecalculateSize(deltaValue);
assertThat(value).isTrue();
}
@Test
public void
shouldRecalculateSize_returnsFalse_ifGetForceRecalculateSizeIsFalse() {
GemFireCacheImpl.DELTAS_RECALCULATE_SIZE = false;
Delta deltaValue = mock(Delta.class);
when(deltaValue.getForceRecalculateSize())
.thenReturn(false);
boolean value = EntryEventImpl.shouldRecalculateSize(deltaValue);
assertThat(value).isFalse();
}
@Test
public void
shouldRecalculateSize_returnsTrue_ifGetForceRecalculateSizeIsFalse_andDELTAS_RECALCULATE_SIZEisTrue()
{
GemFireCacheImpl.DELTAS_RECALCULATE_SIZE = true;
Delta deltaValue = mock(Delta.class);
when(deltaValue.getForceRecalculateSize())
.thenReturn(false);
boolean value = EntryEventImpl.shouldRecalculateSize(deltaValue);
assertThat(value).isTrue();
}
@After
public void tearDown() {
GemFireCacheImpl.DELTAS_RECALCULATE_SIZE = false;
}
```
This way you can add test coverage, improve code readability, and make the
types a bit more clear. You can also extract a non-static method or do further
refactoring but you'll end up needing to do a lot more setUp in the unit tests.
These new tests should also make it obvious that
GemFireCacheImpl.DELTAS_RECALCULATE_SIZE should probably be moved and changed
and tested. But that's another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow individual deltas to trigger bucket size recalculation
> ------------------------------------------------------------
>
> Key: GEODE-8894
> URL: https://issues.apache.org/jira/browse/GEODE-8894
> Project: Geode
> Issue Type: New Feature
> Components: core, serialization
> Affects Versions: 1.14.0
> Reporter: Raymond Ingles
> Priority: Major
> Labels: pull-request-available
>
> The Redis subsystem uses Deltas heavily, but by default deltas do not trigger
> an update to the size of their buckets. This leads to incorrect memory usage
> accounting over the long term, especially with the use of Redis commands like
> "APPEND".
> It is possible to set the system property "DELTAS_RECALCULATE_SIZE", but this
> is a global value that would affect the processing of all deltas, including
> non-Redis operations.
> Instead, we will add a new default method to the Delta interface, that can be
> overridden by individual Delta implementations (such as Redis). This will
> trigger the same behavior as DELTAS_RECALCULATE_SIZE, but on a per-delta
> basis. Thus, other Geode operations will not force bucket size recalculations
> unless the global property is set, but Redis statistics will be correct.
> Other types of delta operations may find this useful in the future.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
