[
https://issues.apache.org/jira/browse/GEODE-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282133#comment-17282133
]
ASF GitHub Bot commented on GEODE-8932:
---------------------------------------
nonbinaryprogrammer commented on a change in pull request #6016:
URL: https://github.com/apache/geode/pull/6016#discussion_r573355624
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/AbstractSetNXIntegrationTest.java
##########
@@ -78,7 +87,18 @@ public void testSetNX() {
assertThat(response3).isEqualTo(0);
}
- private String randString() {
- return Long.toHexString(Double.doubleToLongBits(Math.random()));
+ @Test
+ public void testSetNX_whenCalledConcurrently() {
+ Jedis jedis2 = new Jedis("localhost", getPort(), REDIS_CLIENT_TIMEOUT);
Review comment:
don't forget to close jedis2 at the end of the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support Redis SETNX command
> ---------------------------
>
> Key: GEODE-8932
> URL: https://issues.apache.org/jira/browse/GEODE-8932
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> SETNX is deprecated (and a synonym for) SET... NX. Since we already have
> robust tests for SET... NX, we don't need many more for SETNX.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
